https://bugzilla.wikimedia.org/show_bug.cgi?id=505
Brad Jorsch <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5500 is|0 |1 obsolete| | --- Comment #45 from Brad Jorsch <[email protected]> 2008-12-20 15:16:32 UTC --- Created an attachment (id=5600) --> (https://bugzilla.wikimedia.org/attachment.cgi?id=5600) Updated patch based on Brion's comments I had to change the data format to make it work sanely, but I think it's better this way anyway. If someone wants to add another method of specifying date offsets now, it should be pretty easy to add. Changes since the last patch: * There is now an option for "System time offset", which uses $wgLocalTZoffset. * The format of the 'timecorrection' user option, and thus the various $timecorrection parameters used in Language.php, has changed again. The old style (integer, or hour:minute value) is still accepted for backwards compatibility. Other possibilites are now: ** "System|$minDiff", which specifies that $wgLocalTZoffset is to be used. $minDiff is a copy of $wgLocalTZoffset at the time the preference was last set, and is currently ignored. ** "Offset|$minDiff", which specifies a specific difference in minutes. ** "ZoneInfo|$minDiff|$zone", which specifies a specific zoneinfo timezone. $minDiff is the offset in minutes for the specified timezone at the time the preference was last set, and is used as a fallback in case $zone later cannot be loaded. ** Any new method can be added easily enough in the future, as long as it conforms to the general "$tag|$minDiff|$whatever" layout. * The offset field is now disabled unless "Offset" is selected in the dropdown. The "Fill from browser" button changes the dropdown to "Offset" and fills it in. * The local time and offset are now updated as the fields are changed. This is done by storing the UTC time in minutes in a hidden field, and using the "$minDiff" value from the possible timecorrection values. * Another system message has been added, 'timezoneuseserverdefault', which specifies the text of the "Use server default" option in the dropdown. * It looks like the wfTimestamp timestamps are always in UTC; I'm not sure this won't break if that is ever not true. Of course, I'm not sure the old code won't break in that case either. * The dropdown is now displayed even if the PHP timezone functions are not available, to allow the user to select the server default or a specific offset. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
