https://bugzilla.wikimedia.org/show_bug.cgi?id=505
Brion Vibber <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5600 is|0 |1 obsolete| | --- Comment #46 from Brion Vibber <[email protected]> 2008-12-22 21:31:05 UTC --- Created an attachment (id=5612) --> (https://bugzilla.wikimedia.org/attachment.cgi?id=5612) Modified patch to fix PST bug, tweak text Looks good! A couple minor tweaks in this version: I noticed that the local time display update wasn't working right when I used the detection button. Problem turned out to be that parseInt() by default attempts to interpret numbers starting with a "0" as octal, thus our zero-padded offsets for 8 or 9 hours off from UTC would fail ("-08" -> 0). Passing base 10 explicitly to parseInt() resolves this. I wouldn't have noticed this bug in the summer, when California time is -07:00... ;) Additionally, the offset was saved incorrectly due to use of "+" in PHP code where the concatenation operator "." is needed. ("+" coerces strings to integers in PHP, so we got "-480" instead of "Offset:-480"... the "-480" was then interpreted as -480 hours when re-loaded.) I also went ahead and changed the text string in the drop-down for the explicit-offset selection to "Other (specify offset)", which seems a little more consistent with the UI to me. Ready to commit unless anyone notices any other issues... -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
