https://bugzilla.wikimedia.org/show_bug.cgi?id=15129
--- Comment #13 from Bryan Tong Minh <[email protected]> 2009-01-14 22:01:23 UTC --- A few general comments on this: * You are basically duplicating the CheckUser interface. This is bad because changes in one part of the CheckUser code will not affect other parts. Code duplication should be avoided when possible. * You are constructing raw sql, whereas using the wrapper functions is strongly recommended * Limits are hardcoded * XFF is added as /xff. In the api you will simply want to use a boolean xff parameter -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
