https://bugzilla.wikimedia.org/show_bug.cgi?id=15129
--- Comment #15 from Soxred93 <[email protected]> 2009-01-14 22:20:28 UTC --- > (In reply to comment #13) > > A few general comments on this: > > * You are basically duplicating the CheckUser interface. This is bad because > > changes in one part of the CheckUser code will not affect other parts. Code > > duplication should be avoided when possible. > Bryan's right. You should call existing functions in CheckUser, not copy them. > If CheckUser doesn't have nice functions for your purposes, create them and/or > adapt existing ones to be nice to you. All the functions in the CheckUser class are protected functions, and I can't have the code output them. In addition, they output pure HTML (which is bad in its own right). The entire CheckUser code could use a rewrite. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
