https://bugzilla.wikimedia.org/show_bug.cgi?id=17563
--- Comment #1 from Brad Jorsch <[email protected]> 2009-02-19 03:02:15 UTC --- Created an attachment (id=5830) --> (https://bugzilla.wikimedia.org/attachment.cgi?id=5830) Patch against r47478 to fix the issue This looks like a large patch, but it's mostly indentation. The actual changes are: * The whole block of code calling addValue is only called if $resultPageSet is null (i.e. non-generator mode). This results in all the indenting. * $this->resultArr is passed through array_values in the "try to add them all at once" case, so the output is as an array instead of an object. * In the "add elements one by one" case, similarly don't specify a key. * Slight rearrangement at the bottom of the function to eliminate a redundant conditional. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
