https://bugzilla.wikimedia.org/show_bug.cgi?id=17563
Roan Kattouw <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Status|NEW |RESOLVED Resolution| |FIXED --- Comment #5 from Roan Kattouw <[email protected]> 2009-02-19 21:55:57 UTC --- (In reply to comment #1) > Created an attachment (id=5830) --> (https://bugzilla.wikimedia.org/attachment.cgi?id=5830) [details] > Patch against r47478 to fix the issue Applied verbatim in r47514. (In reply to comment #2) > It's considered good form to separate whitespace/code formatting and actual > code changes when constructing patches. > If the whitespace changes are completely unrelated, that's definitely true. This case, where an if() is added and the statements inside it are indented and changed is kind of a corner case. I decided to commit the whole thing in one go, but having a patch without whitespace changes certainly made review clearer. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
