https://bugzilla.wikimedia.org/show_bug.cgi?id=26028

--- Comment #26 from Candalua <[email protected]> 2011-10-28 23:11:29 
UTC ---
(In reply to comment #25)
> (In reply to comment #23)
> > (In reply to comment #22)
> > > that is not the fix! that is the bug itself! :-) see comment 15 where 
> > > Andrew
> > > Billinghurst writes about Phe's suggested change. In short words, we need 
> > > that
> > > line break to be *removed*!
> > Did so in r101183, and deployed. Is it fixed now?
> 
> The main problem seems to be fixed but another one has appeared:
> 
> If no line break is inserted after the <noinclude> tag the last line will
> appear as a own paragraph in the "page"-namespace. 
> http://sv.wikisource.org/w/index.php?title=Sida%3ANils_Holgerssons_underbara_resa_genom_Sverige%2C_band_1.djvu%2F95&action=historysubmit&diff=147571&oldid=147564
> 
> Although this can be mended manually and doesn't effect the transcluded part,
> it will become very tedious in the long run.


I propose this fix: add a newline after <noinclude> on saving, but only if
$editpage->footer does not start with a newline. This way we're not adding a
new newline on every save (that was the original problem), and in the same time
we make sure that the footer is always separated from the body by a newline. 

BTW, thank you very much for fixing the main problem!

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to