https://bugzilla.wikimedia.org/show_bug.cgi?id=26028

--- Comment #27 from Philippe Elie <[email protected]> 2011-10-29 15:12:50 UTC ---
> > 
> > The main problem seems to be fixed but another one has appeared:
> > 
> > If no line break is inserted after the <noinclude> tag the last line will
> > appear as a own paragraph in the "page"-namespace. 
> > http://sv.wikisource.org/w/index.php?title=Sida%3ANils_Holgerssons_underbara_resa_genom_Sverige%2C_band_1.djvu%2F95&action=historysubmit&diff=147571&oldid=147564
> > 
> > Although this can be mended manually and doesn't effect the transcluded 
> > part,
> > it will become very tedious in the long run.
> 
> 
> I propose this fix: add a newline after <noinclude> on saving, but only if
> $editpage->footer does not start with a newline. This way we're not adding a
> new newline on every save (that was the original problem), and in the same 
> time
> we make sure that the footer is always separated from the body by a newline. 
> 
> BTW, thank you very much for fixing the main problem!

Agreed, the trouble is we really need a linefeed either before the noinclude
(which break transclusion) or after the noninclude tag (but if added
unconditionally it breaks because this LF is added to existing one), without
any linefeed, as actually, the sequence "last line - 1\nlast
line<noinclude><references /></div></noinclude> generate a <p> between line1
and line2 see
http://fr.wikisource.org/w/index.php?title=Page:Chaptal_-_Chimie_appliqu%C3%A9e_%C3%A0_l%E2%80%99agriculture,_Tome_1.djvu/139&oldid=2869917
and the sequence "\n\nlast line<noinclude><references /></div></noinclude>
doesn't generate a <p> before the last line, see
http://fr.wikisource.org/w/index.php?title=Page:Chaptal_-_Chimie_appliqu%C3%A9e_%C3%A0_l%E2%80%99agriculture,_Tome_1.djvu/139&oldid=2869942.
So there is no way to get the wanted generated code in Page: namespace.
Candalua solution should work.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to