https://bugzilla.wikimedia.org/show_bug.cgi?id=16950


Aryeh Gregor <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
                   |                            |m




--- Comment #11 from Aryeh Gregor <[email protected]>  2009-04-01 
20:54:52 UTC ---
The patch seems to go to great lengths to only show moves and deletes. 
Wouldn't it be simpler (and possibly more future-proof) to just show all log
entries for the page?  The last one is always going to be the relevant move or
deletion, anyway.

If there is some way to display multiple logs, it should surely be abstracted
into LogPager, not done on the caller side and duplicated in two different
places.  Actually, it looks like you could already do something like

                $pager = new LogPager( $loglist, array('move', 'delete'),
false, $this->mTitle->getPrefixedText() );

and it might magically work, from a glance at the source code.  You'd want to
adjust LogPager::limitType() to handle this more explicitly, specifically in
the $wgLogRestrictions check on about line 547, but it looks like it would be a
simple change.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to