https://bugzilla.wikimedia.org/show_bug.cgi?id=16950
Aryeh Gregor <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #17 from Aryeh Gregor <[email protected]> 2009-04-24 17:24:55 UTC --- Committed as r49821 with the following tweaks: - * @param $type String: A log type ('upload', 'delete', etc) + * @param $type String or array: Log types ('upload', 'delete', etc) $type -> $types (in r49822) + // If $type is not an array, make it an array $type -> $types + $types = array_diff( $types, array( $t ) ); $t -> $type + if ( count( $types ) == 0 ) { + $types = ''; + } Removed, array() evaluates to boolean false, so this isn't needed. Also note for the future that you shouldn't add RELEASE-NOTES changes to your patches -- they're easy for the committer to add, and they'll virtually always cause a conflict when the committer tries to apply the patch. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
