https://bugzilla.wikimedia.org/show_bug.cgi?id=34590
--- Comment #13 from Nicolas Brouard <[email protected]> 2012-03-05 09:24:07 UTC --- (In reply to comment #12) > I'm not really a fan of this idea. It just seems wrong (in a gut feeling kind > of way; Don't really have a logical reason) to use email as a log in > credential. > Thanks for reviewing the patch. > I would much prefer we provided an on-screen keyboard type thing, or some > other > solution, to allow people to actually type their username, rather then letting > people log in with email. > This is an opinion only (already discussed by some people) and it is more an opinion of a developer that from a user (I think). > ---- > In regards to the patch: > *For future reference, don't worry about any of the translation files except > for english (and qqq). Non-english translations are handled elsewhere by a > different group of people (translatewiki). As I wrote, I need these 20 languages and the translation is currently operational on our wikis. > *The patch doesn't actually work because it tries to apply title normalization > to the user's input, but emails aren't usually title normalized (aka emails > often start lowercase, but the code in patch capitalizes first letter. ditto > for underscore). Every one knows that the title normalization of Wikipedia is already useless in many languages. Uppercase is really from a western culture. Thus when you say "doesn't actually work", you could have written "is not appropriate" or something more neutral. I just kept the same transformation (title normalization) in order to show that the patch is very simple and that you should not see any complication by suppressing the normalization. But an email normalization could look better. On our system, and using mysql, it works. I haven't tested with postgresql. > *Type an email in special:contributions. You can now given an email, associate > a user with that email. That's a bad thing (emails are supposed to be secret). This point is very very important. But from what you said, I am sure that if you reviewed the patch, you did not test it! As said in previous discussions, if you enter an email instead of a username in Special:UserContribution, you get nothing: ------------------------ User contributions For [email protected] (talk | block log | uploads | logs) Search for contributions Show contributions of new accounts only IP address or username: Namespace: Deleted only Only show edits that are latest revisions From year (and earlier): From month (and earlier): No changes were found matching these criteria. ------------------- but if you enter the name "Nicolas Brouard" you get: ------------------- (Latest | Earliest) View (newer 50 | older 50) (20 | 50 | 100 | 250 | 500) 12:29, 1 November 2011 (diff | hist) Talk:62 (Zeugungsunfähigkeit) (top) 09:06, 10 October 2011 (diff | hist) N Category:Term of the second edition of the multilingual demographic Dictionary (redirect) (Some explanations) (top) 23:25, 24 September 2010 (diff | hist) Template:NewTextTerm (top) 18:55, 24 September 2010 (diff | hist) m Category:To be checked (top) 18:30, 24 September 2010 (diff | hist) Category:To be checked (Which pages should I check?) 18:26, 24 September 2010 (diff | hist) m Category:To be checked (→Summary of parameters of NewTextTerm or TextTerm) -------------- > Marking patch as reviewed do to the above mentioned issues. Needs probably tests and not only reviews. I can provide logins if somebody want to test the patch. Regards -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
