https://bugzilla.wikimedia.org/show_bug.cgi?id=34590
--- Comment #18 from Chad H. <[email protected]> 2012-03-05 20:56:13 UTC --- (In reply to comment #15) > (In reply to comment #14) > > > By doesn't actually work I do mean doesn't actually work. My email address > > on > > my test wiki install is bawolff@localhost. Typing "bawolff@localhost" in to > > the > > log in box does not log me into the account, as this patch looks for user's > > with the address "Bawolff@localhost" (I also tried an account with an email > > address containing underscores which failed for similar reasons. These were > > not > > bad examples meant to make the patch fail. These were the pre-existing > > emails > > that were on my test wiki). > > @localhost can't be considered as a valid email, at least not for a user but > for a developper ok. But the patch works, you can't authenticate this way but > need your real username. > > The patch is valid for MOST users, not all I agree. What I understand from > your > Bawolff@localhost address is that you have a Linux account on the Wikipedia > servers. Would it be possible to process the mysql test of my Comment #9? With > its result we could refine our estimation of what MOST means (suppressing also > addresses @localhost) and thus have a better of how many wikipedians users > could benefit of such a patch. > It's not only valid for developers (although that's the most common scenario). You could have all of your e-mail inside your company in the form of user@some-host-without-a-tld. If this is going to be accepted, it should follow the same rules of isValidEmailAddr() or whatever we call it these days, not just e-mails in [email protected] form. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
