https://bugzilla.wikimedia.org/show_bug.cgi?id=34778
Bawolff <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #6 from Bawolff <[email protected]> 2012-04-04 14:34:35 UTC --- This extension currently involves patches to core mediawiki, which is generally a big no no. It also doesn't follow some of Wikimedia's coding conventions. For example: *Using $_SERVER directly, instead of looking at $wgServer variable, etc. Another example: if ( !stripos( $_SERVER['REQUEST_URI'], '?' ) && !stripos( $_SERVER['REQUEST_URI'], 'Special:TimeGate' ) ) { *Using $dbr->query instead of $dbr->select *Hard coded strings that should be i18n-ized *Things like: $page_namespace_id = constant( "NS_" . strtoupper($namespace) ); which make assumptions that may not be true in many setups *Using echo in places where $wgOut->disable() has not been called. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
