https://bugzilla.wikimedia.org/show_bug.cgi?id=34778
--- Comment #7 from Harihar Shankar <[email protected]> 2012-04-04 15:01:42 UTC --- Thanks for your comments. I will fix the plugin to incorporate these suggestions. Clarification on patching MediWiki Core: The patch to the core of mediawiki is needed only when older versions of Templates are to be fetched by the plugin. This patch is not mandatory for this plugin to work. (In reply to comment #6) > This extension currently involves patches to core mediawiki, which is > generally > a big no no. > > It also doesn't follow some of Wikimedia's coding conventions. For example: > > *Using $_SERVER directly, instead of looking at $wgServer variable, etc. > Another example: > if ( !stripos( $_SERVER['REQUEST_URI'], '?' ) && !stripos( > $_SERVER['REQUEST_URI'], 'Special:TimeGate' ) ) { > > *Using $dbr->query instead of $dbr->select > > *Hard coded strings that should be i18n-ized > > *Things like: $page_namespace_id = constant( "NS_" . strtoupper($namespace) ); > which make assumptions that may not be true in many setups > > *Using echo in places where $wgOut->disable() has not been called. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
