https://bugzilla.wikimedia.org/show_bug.cgi?id=12701
--- Comment #21 from Roan Kattouw <[email protected]> 2009-05-18 16:35:56 UTC --- (In reply to comment #20) > (In reply to comment #19) > > Adding Title::getPreviousRevisionIDAtOffset() is of no use, since we've got > > Revision::getPrevious() already. Also, there's only one entry per user in > > the > > user_newtalk table AFAIK, so returning the number of entries is useless as > > well > > in that case. > > > There is an entry for every edit for user's talk page. At least that's what in > user_newtalk in my local db. So, there will be one entry or more, Right. > so i don't > think that Revision::getPrevious() would help me that much. > Those two aren't related. My point is that you're duplicating code from Revision::getPrevious() to Title::getPreviousRevisionIDAtOffset() for no good reason. To get the previous revision ID for a certain revision ID you should really just create a Revision object for it (if you don't have one already) with Revision::newFromID() and call getPrevious() on it. > > Also, instead of using the 'newmessage' and 'newmessages' messages, you > > should > > use {{PLURAL:}}. > > > This could be done, but after reviewing the patch to see if it can be > committed > to the trunk or thrown in the trash :). > ... or you could do it now; developers are typically more hesitant to commit patches that need fixing up. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
