https://bugzilla.wikimedia.org/show_bug.cgi?id=12701
--- Comment #23 from Roan Kattouw <[email protected]> 2009-05-18 17:26:24 UTC --- (In reply to comment #22) > (In reply to comment #21) > > Those two aren't related. My point is that you're duplicating code from > > Revision::getPrevious() to Title::getPreviousRevisionIDAtOffset() for no > > good > > reason. To get the previous revision ID for a certain revision ID you should > > really just create a Revision object for it (if you don't have one already) > > with Revision::newFromID() and call getPrevious() on it. > > > > AFAIU, Revision::getPrevious(), just like Title::getPreviousRevisionID, gives > me *only* the previous revision, I need, for example, 5th revision before the > current revision, so I will have to use a loop or something using > Revision::getPrevious() to get only the rev id to put it in the link. > Title::getPreviousRevisionIDAtOffset() gives me the rev id directly or I'm > missing something. > Hmm. This is probably justified, but it still gives me the creeps. Implementing this more cleanly would require a schema change though. > > ... or you could do it now; developers are typically more hesitant to commit > > patches that need fixing up. > > > > On a second thought, will {{PLURAL:...}} allow us to make a link from 'a new > message' or 'new messages'? Sorry if the question is stupid :). > It'll allow something like {{PLURAL:$1|a new message|$1 new messages}} where $1 is substituted with the number of messages. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
