https://bugzilla.wikimedia.org/show_bug.cgi?id=40679

Krinkle <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #7 from Krinkle <[email protected]> 2012-10-02 03:02:21 UTC ---
(In reply to comment #6)
> I guess I'm the only one in favor of killing $wgServer altogether?
> 
> I think a situation in which you have two variables—$wgHTTPServer and
> $wgHTTPSServer—in which you explicitly define the secure and non-secure
> canonical URL versions would be better from a wiki administration perspective
> and a coding perspective. The protocol-relative magic feels very fragile to 
> me.
> 

There is no need to have two variables. Earlier last year (before we started
using relative protocols) this is exactly what we had. By default we set
$wgServer = 'http://example.org'; and on the secure servers to https.

The reason we went for protocol-relative instead is because we now serve pages
from the main servers, and we want to share the HTML cache. Having two
variables solves nothing but introduces a lot of problems. Because that means
you'll have to split the cache in a version where the HTML contains http://
everywhere and one with https://, since that is pointless and a problem already
solved by the web, we use protocol-relative urls instead starting with //.

The problems we have aren't solved by introducing that, and introducing that
pattern is already possible without those 2 variables:

> $wgServer = isHttps() ? 'http://example.org' : 'https://example.org';

We don't need the other value anyway when in the other request type.

Except that we do, which is why we have a canonical protocol for API responses.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to