https://bugzilla.wikimedia.org/show_bug.cgi?id=40679
--- Comment #14 from Krinkle <[email protected]> 2012-10-02 06:35:13 UTC --- (In reply to comment #13) > My general feeling is that whenever $wgServer is mentioned (in discussions or > in code), it's always a guessing game with its value is. HTTP, HTTPS, > protocol-relative? And this guessing game has a cost. An alternative approach > is to be explicit in the variable name itself, so that there's less ambiguity. > I don't see the problem here. $wgServer is a configuration variable to set how MediaWiki should represent self-reference urls. If only HTTP or HTTPS is supported (most common) it is set to one of those. Having a $wgHTTPSServer variable doesn't make sense. What would you set it to if a server only supports HTTP, I guess you'll have to set it to http:// then because the server doesn't have https. And what if both are supported (like on Wikipedia), which does it use in the parser? Neither, because those urls can (and should be) without protocol so that they are relatively interpreted by the browser, because the visitor can be on either http or https. $wgServer indicates what the server supports. http, https or both. And in most cases $wgServer can/should be used as-is (without trying to expand it). And if a server preference is needed, then it can be ran through wfExpandUrl (e.g. for wgSecureLogin it will expand to HTTPS if the server supports that. Obviously if the server doesn't support HTTPS it shouldn't try to link there as it would be a broken link pointing to a server error. And if you don't support HTTPS, well, then it doesn't make sense to enable wgSecureLogin. Either way enabling wgSecureLogin when not supported is harmless afaik, it simply maintains http as it would other wise). Before we get into a very generic discussion, what is the actual bug here? What is the problem? How to reproduce this redirect problem? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
