https://bugzilla.wikimedia.org/show_bug.cgi?id=32906

--- Comment #19 from Daniel Friesen <[email protected]> 
2012-11-10 17:41:26 UTC ---
(In reply to comment #18)
> (In reply to comment #16)
> > Looks like the system already supports passing a 'variant' parameter on the
> > request, it's just that since it's handled internally by LanguageConverter 
> > and
> > friends it's not documented on the API. :)
> > 
> > We'd still need to export them in a machine-readable way, or hardcode them 
> > in
> > the app (easy but annoying to maintain), then make sure we have a UI for
> > selecting it and include it in the request.
> 
> It seems the language converter go to check $wgRequest for variant directly 
> and
> it's a part of the parsing process. Does this violate the "No $wg*** in 
> Parser"
> principle, or al least should be context-fied?

As far as I can see the variant code doesn't use any request data in the parser
context.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to