https://bugzilla.wikimedia.org/show_bug.cgi?id=42198
--- Comment #15 from Bartosz Dziewoński <[email protected]> --- (In reply to comment #12) > So the best this to do now is understanding once and for all the original > code. > According to the blame, Trevor Pascal made this code. Do you have a way to > ask > him about his code? > For instance : > # what is the meaning of an action function that does nothing > # what is the meaning of an action function that returns false (or true) > # what is the meaning of : #dialogID.dialog( 'open' ) While I am not the author, I can explain this briefly. Action function that does nothing simply does nothing. It doesn't even cancel form submission, which is what normally happens when a form button is clicked. That's why the cancelling saved the page. Action function that returns false cancels form submission. Returning true has no "meaning". `$( '#' + dialogID ).dialog( 'open' )` (which is what I assume you're referring to) opens a dialog which has the id contained in the `dialogID` variable. (This is a WikiEditor-only extension to jQuery.) The dialog apparently has to be initialized first, and since it wasn't, this didn't work. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
