https://bugzilla.wikimedia.org/show_bug.cgi?id=44299
--- Comment #11 from Krinkle <[email protected]> --- So why did you add it as a selenium test in Iadda6170? You could've added in mediawiki core's qunit test instead. I don't maintain selenium tests so do as you like, but an explanation or counter argument would help me understand it your decision. If you don't want to run qunit tests before triggering selenium, how about writing selenium code to go to Special:JavaScriptTest/qunit and running all the qunit tests before anything else? I still stand (though I'd like to be convinced other wise) on this assertion being a unit test and belonging in and only in the qunit test suite (not in selenium integration tests). The last thing we'd want is two different test phases asserting the same thing. Just like we don't do linting checks in qunit, we shouldn't be doing unit tests in selenium. See also comment 3 and bug 44488. Only run selenium tests after making sure qunit tests pass. If you don't then you'll only get caught up in trying to catch everything that can go wrong, and that's a whole lot of things too many. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
