https://bugzilla.wikimedia.org/show_bug.cgi?id=44299
--- Comment #13 from Krinkle <[email protected]> --- Well, Selenium doesn't run from the standard Jenkins jobs either, so that doesn't justify anything. I meant that a human (or Selenium driven script) can easily "run" the QUnit test before proceeding to the integration tests. Also, Antoine and I are getting really close to getting QUnit tests to run on every commit. It would be useful to have this unit test be part of the unit test suite. What has been done before doesn't justify anything. Generally if something involves only javascript, and involves javascript calling a function and directing asserting the outcome, that's best done as a unit test. I'm not saying Selenium can't do it. It is very good as reaching out to the javascript engine and executing arbitrary strings of code. What I mean is, when a developer is working developing, there's a limit to what is reasonable to run periodically when testing and working with things before committing. That generally involves linting and unit testing. Not cross-browser integration tests (not yet anyway). So aside from what is semantically correct (though I think this is semantically a unit test), it is currently more useful for it to be a unit test so that more people naturally run into it more often in the current state of reality. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
