https://bugzilla.wikimedia.org/show_bug.cgi?id=43360
Jack D. Pond <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #4 from Jack D. Pond <[email protected]> --- Yaron (etal). Agreed the problem occurs, but fix is relatively simple. The problem is that MW strips ALL URL query components, including the essential "title=" In order to make this work for a form button, the "title" also has to be included as one of the "hidden" values. With the below patch, if you look at the URL, you'll still see the "title=" component in the GET URL, but it is irrelevant and ignored - could probably be eliminated. diff --git "a/git./SF_Utils-5bfa36b-left.php" "b/SF_Utils.php" Index: includes/SF_Utils.php --- "a/.git/includes/SF_Utils-5bfa36b-left.php" +++ "b/includes/SF_Utils.php" @@ -899,12 +899,14 @@ END; } $hidden_inputs = ""; if ( ! empty( $inQueryArr ) ) { - // Special handling for the buttons - query string + // Special handling for the buttons - query string and title // has to be turned into hidden inputs. if ( $inLinkType == 'button' || $inLinkType == 'post button' ) { - + $tpos = strpos( $link_url , '?title='); + if ( $tpos == true ){ + $hidden_inputs .= Html::hidden( urldecode( "title" ), urldecode( substr($link_url, $tpos + strlen('?title=') ) ) ); + } $query_components = explode( '&', http_build_query( $inQueryArr, '', '&' ) ); - foreach ( $query_components as $query_component ) { $var_and_val = explode( '=', $query_component, 2 ); if ( count( $var_and_val ) == 2 ) { -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
