https://bugzilla.wikimedia.org/show_bug.cgi?id=43360
--- Comment #7 from Jack D. Pond <[email protected]> --- Daniel (and Laxstrom) I totally agree about the ugly hack - and if there are suggestions on improvement, please submit. HOWEVER, if you look at rest of the code as it relates to button in createFormLink: 1. If I'm reading the code right, the other query params are already being handled correctly by adding them as hidden values 3 lines subsequently. 2. The only query that isn't being handled by this is the "title" param and this hack handles that (and only that) exception. 3. The "title" param is returned as part of the getTitle()->getLocalURL(). If there is a way to get ONLY the ugly "title" param, it would probably be more appropriate (I'm just not aware) 4. The hack leaves the "title=" in the URL, which is ignored, but confusing. Is it worth removing? Is there a possible security implication in leaving it visible? Should it be removed? 5. As ugly as this is, I believe it covers all conditions and solves the problem. As Yaron stated, the alternative is to use POST, but I'm assuming there is a reason somewhere (in my case, legacy apps), that GET is preferred. I'd appreciate any improvements!!!!! -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
