https://bugzilla.wikimedia.org/show_bug.cgi?id=46655

       Web browser: ---
            Bug ID: 46655
           Summary: ConfirmEmailComplete fires again if you confirm an
                    already-confirmed email
           Product: MediaWiki
           Version: 1.21-git
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: Special pages
          Assignee: [email protected]
          Reporter: [email protected]
    Classification: Unclassified
   Mobile Platform: ---

None of Special:ConfirmEmail, User::newFromConfirmationCode, and
User::confirmEmail check if an email is already confirmed. 
newFromConfirmationCode just checks if it's a valid non-expired code, but using
a code does not expire it.

It's fine not to show an error for double confirmations, but the hook should
not fire twice.  I don't think setEmailAuthenticationTimestamp should be called
again either, so my patch will avoid doing so.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to