https://bugzilla.wikimedia.org/show_bug.cgi?id=46655

--- Comment #1 from Matthew Flaschen <[email protected]> ---
Proposed fix at https://gerrit.wikimedia.org/r/56539

It calls isEmailConfirmed to see if they're already confirmed.  If so, it
returns true without doing anything.

This does mean the EmailConfirmed hook (called by isEmailConfirmed) will be
called in an additional scenario.  However, isEmailConfirmed seems to be called
frequently already (e.g. by both canSendEmail and canReceiveEmail).

The fix means you can do something user-facing (e.g. sending an email to the
user) on ConfirmEmailComplete without that occurring twice if the URL is
visited again when they're already confirmed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to