https://bugzilla.wikimedia.org/show_bug.cgi?id=47872
--- Comment #10 from Krinkle <[email protected]> --- (In reply to comment #7) > So how hard would it be to get the site&user scripts to run first, then > $.ready, then the rest of the bottom queue? Then we could kill off > mwCustomEditButtons after announcing it properly and revert the change > (unless > there is a considerable number of other scripts this would break). > > [Disclaimer: I know next to nothing about ResourceLoader internals.] site&user script run after the bottom queue by design. Just like the cascading stylesheets, they are intended and designed to allow overriding/customising things after everything else. Though presence of code will not make a difference (since bottom queue is async), the loading is affected. Code in site and/or user scripts that are wrapped in mw.loader.using would trigger additional http requests instead of tagging along on the already pending request for the bottom queue (this is ResourceLoader internals). I'd recommend we add some code to mediawiki.action.edit to periodically check mwCustomEditButtons. Then immediately deprecate it (not removing it, just marking it as deprecated) and phasing it out over the following weeks (I'd like to add it to the js-deprecations train roll-out in May which will introduce mw.log.deprecate and console.warn messages that users can use to easily see if they are using something that is deprecated). Then we can safely remove mwCustomEditButtons in the 1.22 release. (In reply to comment #6) > (In reply to comment #5) > > Rephrasing bug to be about mwCustomEditButtons to avoid mixed subjects. > > See my comment above. There may be other similar structures existing there. Possible indeed, though unlikely as most legacy things have been phased out. Examples are welcome :) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
