https://bugzilla.wikimedia.org/show_bug.cgi?id=47872

--- Comment #12 from billinghurst <[email protected]> ---
(In reply to comment #11)
> (In reply to comment #9)
> > billinghurst, this has nothing to do with switching to the new toolbar;
> > mw.toolbar.addButton works with and is intended for the old one, and the
> > change
> > is just a simple find and replace:
> > 
> >   Find:         mwCustomEditButtons[mwCustomEditButtons.length] = { ... }
> >   Replace with: mw.toolbar.addButton({ ... })
> > 
> > Just be careful about braces and parentheses.
> > 
> > Here's an example diff:
> > https://nl.wikipedia.org/w/index.php?title=Gebruiker:Romaine/vector.
> > js&diff=37497149&oldid=37497060
> 
> Thanks. This innovation had escaped me, and clearly a whole community that
> was
> using mwCustomEditButtons. I will relay this to the enWS community, and fix
> our
> help pages.
> 
> Can you recommend that right page to watch for these changes.  I thought
> that I
> had watched all the relevant pages where Krinkle does these components,
> however, it is clear that this change wasn't evident for active changes.

Clearly it was a long time ago as I have since found reference that it was
broken in 1.18, but somehow it didn't break for all. Weird.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to