https://bugzilla.wikimedia.org/show_bug.cgi?id=48378

--- Comment #2 from Brad Jorsch <[email protected]> ---
(In reply to comment #0)
> I don't know why gsub is used in function mw.text.trim in mw.text.lua; 

No particular reason.

> I would have written that function as following:

Any reason? In some quick testing here, they're both about the same speed
(180-200µs each).

> Also I would have made a mw.text.trim using the string library, and a
> mw.text.utrim using ustring, since it would probably be used most of the time
> with 1-byte characters...

OTOH, that would require callers to know whether they should call mw.text.trim
or mw.text.utrim.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to