https://bugzilla.wikimedia.org/show_bug.cgi?id=47407

--- Comment #3 from Kelson [Emmanuel Engelhart] <[email protected]> ---
My feedback, sorry if I only speaks about things which does not work ;)

* Should be good to have a help about the availabel options and purposes
printed by calling "zimcheck" or "zimcheck --help" or "zimcheck -h"

* By running it against ICD-10, it seems to be a problem with the favicon...
but in favicon is OK AFAIK

* It reports a "unknown mime type code 65535" (with the same file"... this is
unclear what it means for me.

* In the code add the license on the top of the file (GPL2 for the openzim
project)

* Regarding the redundancy check computing a hash for all the contents in every
case seems to me to be a little bit slow. I propose a way to get it done
faster:
1 - go trough all articles and all and save the size
2 - for all articles with the same size make a hash comparison

* I think the check of internal urls will always returns false for the simple
reason that this is allowed to have external links "href" (but not external
dependencies) in the pages... and that is what you check.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to