https://bugzilla.wikimedia.org/show_bug.cgi?id=47407
--- Comment #5 from Kelson [Emmanuel Engelhart] <[email protected]> --- * Usage is more or less OK (few visual things to fix, have a look to the help of tools like "grep" or "perl"). The way to get it should use pre-existing code and not reinventing the wheel, have a look to "getopt" * "./zimcheck ICD10-fr.zim" prints the usage(), it should run the checks. * Code style should be similar to the rest of the zimlib and clean. My general advise is: Take your time and try to code as perfectly as you can. Don't ask for a review if you see yourself a better way to do it, still something you could improve. What matters is the quality, not the quantity. Don't try to do everything/all features, focus on a few features, but try to implement them is the most intelligent and beautiful manner. And the most important: test your own code as much as possible. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
