https://bugzilla.wikimedia.org/show_bug.cgi?id=14801
ChrisiPK <chris...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #6569 is|0 |1
obsolete| |
--- Comment #28 from ChrisiPK <chris...@gmail.com> 2009-09-22 22:23:03 UTC ---
Created an attachment (id=6576)
--> (https://bugzilla.wikimedia.org/attachment.cgi?id=6576)
Patch (unreversed, with unified diff) for Special:Undelete
(In reply to comment #27)
> 1. The patch is reversed.
> 2. Use unified diff when possible.
> 3. By removing 'deletedhistory', and the part of "!$wgUser->isAllowed(
> 'deletedhistory' )" you're allowing everyone to see the deleted history.
> 4. Why are you removing the 1143,1155d1126 and 1195,1200d1165 chunks?
>
1. Indeed it is, sorry about that. I still haven't completely mastered the diff
tool.
2. I think I found the relevant option, the new patch should be "unified".
3. As you already noted, the patch is reversed. I removed the need for the
deletedhistory permission in SpecialPage.php as this prevents users from
viewing the page unless they have this right (which not everyone with
view-deleted-ns-# might). That is why I added a check in SpecialUndelete.php,
see the new patch at @@ -625,6 +637,10 @@.
4. Once again, the patch is reversed, so I am not removing them, but adding
them. They take care of the newly introduced variable mAllowedView, which
determines whether you are allowed to view the revision (unlike mAllowed, which
determines whether you are allowed to restore it).
Best Regards and sorry for the double patch.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
