https://bugzilla.wikimedia.org/show_bug.cgi?id=14801
--- Comment #29 from Brion Vibber <br...@wikimedia.org> 2009-09-23 20:14:37 UTC --- Couple quick notes... The patch doesn't apply cleanly against development trunk; lots of stuff has changed internally since 1.15, so this'll be a lot easier to get merged if it's rebuilt against trunk instead of a release branch. I also see some code duplication, copying portions of the UI output between the can-restore and can't-restore cases. This is easy to do the first time around, but makes code maintenance harder -- the copies can get out of sync easily, and generally just clutter the codebase. I would recommend merging the two cases together; just don't output the form fields when they won't be needed. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
