https://bugzilla.wikimedia.org/show_bug.cgi?id=61841
Bug ID: 61841
Summary: Re-examine API module permissions (isAllowed,
isBlocked) checks
Product: MediaWiki
Version: 1.23-git
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Unprioritized
Component: API
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected], [email protected],
[email protected], [email protected],
[email protected], [email protected]
Web browser: ---
Mobile Platform: ---
https://gerrit.wikimedia.org/r/#/c/114974/2/api/ApiGroupReview.php,unified
seems to have a bad code smell to me. Do we really require every API module to
define "isAllowed" and "isBlocked"? That seems like a flawed architectural
design to me, if so. When being extended, it seems to me that the base
MediaWiki API should be able to handle these checks implicitly, to avoid
situations like this.
Or, alternately, perhaps we need to fail faster when these checks are missing.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
