https://bugzilla.wikimedia.org/show_bug.cgi?id=61841

Brad Jorsch <bjor...@wikimedia.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|Normal                      |Low

--- Comment #1 from Brad Jorsch <bjor...@wikimedia.org> ---
A nitpick: We don't require API modules to "define" any such methods. But if
something wants to check for user rights or for blocked status then it needs to
*call* (not "define") the methods to check for user rights or blocked status.

This seems to me as little different from now the rest of MediaWiki handles
permissions checks, except for Special pages. And even many special pages need
to go beyond the simple checks provided for in the base class. So no, I don't
think that we need to try to cram flags for block and permissions checking into
the already-overgrown API base classes.


Regarding that linked change in particular, it sounds like they have code
duplication with their web UI code and their API code. Instead there should be
some back-end method that does the actual work and returns status to the UI
layer and both the web UI and the API should be calling that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to