https://bugzilla.wikimedia.org/show_bug.cgi?id=62614

--- Comment #19 from Chris McMahon <cmcma...@wikimedia.org> ---

Seems like a race condition in lines 204-208 of SpecialMobileOptions.php in
submitSettingsForm. 

As I read this: 

* submitSettingsForm calls out to do "$context = MobileContext::singleton();"
and also "$request = $this->getRequest();"

** both of these must take time

* then the code immediately compares tokens with "if ( $request->getVal(
'token' ) != $context->getMobileToken() )"  

It seems to me like submitSettingForm should wait for both $request and
$context to complete before comparing values obtained from those operations.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to