https://bugzilla.wikimedia.org/show_bug.cgi?id=65352
--- Comment #1 from Rob Moen <[email protected]> --- > clarified as a documentation improvement). However, I would have thought > it's for all (pre, post, and control). The docs currently say, "Log server > side event if we acquired the user through pre or post edit call to action", > which is not consistent with that. > > However, I don't see anything in the code that actually restricts to > pre/post. At one point pre-merge we were logging only impression and creation schemas when directly handed to account creation from the CTA. Phuedx and I discussed this and we determined to only check for the token. Then we can compare that token against the CTA. This affects our ability to detect if they came directly from the CTA prior to signing up. > Finally, I think it should use AddNewAccount > (https://www.mediawiki.org/wiki/Manual:Hooks/AddNewAccount), since that > actually fires for new accounts, so e.g. refreshing a page or > bookmarking/returning will not cause extra firings. > I agree that might be a better approach to gathering the user. Though we are already subscribing to the central auth redirect hook. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
