https://bugzilla.wikimedia.org/show_bug.cgi?id=65352
--- Comment #7 from Matthew Flaschen <[email protected]> --- Aaron and I discussed further on IRC, and there are in fact some schema issues, as well as the hooks to be updated. (In reply to Matthew Flaschen from comment #0) > The SignupExpAccountCreationComplete (and > SignupExpAccountCreationImpression, which should be updated similarly while > we're at this) does not say which conditions it's fired for (this should be > clarified as a documentation improvement). However, I would have thought > it's for all (pre, post, and control). The docs currently say, "Log server > side event if we acquired the user through pre or post edit call to action", > which is not consistent with that. Documentation clarified: * https://meta.wikimedia.org/w/index.php?title=Schema%3ASignupExpAccountCreationComplete&diff=8539421&oldid=8102589 * https://meta.wikimedia.org/w/index.php?title=Schema%3ASignupExpAccountCreationImpression&diff=8539445&oldid=8102591 It is for everyone, and token is an optional field (this clarification implies a code change). > However, I don't see anything in the code that actually restricts to > pre/post. This is correct behavior. I've removed that comment in https://gerrit.wikimedia.org/r/133667. > Finally, I think it should use AddNewAccount > (https://www.mediawiki.org/wiki/Manual:Hooks/AddNewAccount), since that > actually fires for new accounts, so e.g. refreshing a page or > bookmarking/returning will not cause extra firings. Done. > Similarly, UserCreateForm is a simpler and more performant (since there's > not an extra if on every unrelated page load) way of checking if they're on > the signup page (but it only works if we don't need to assign a token to > every visitor the 'create account' page). Done. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
