https://bugzilla.wikimedia.org/show_bug.cgi?id=23302

           Summary: Hard coded OldLocalFile Class in LocalFile::getHistory
                    stops custom File Repos
           Product: MediaWiki
           Version: 1.17-svn
          Platform: All
               URL: http://www.mediawiki.org/wiki/Extension:NSFileRepo
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: Normal
         Component: Images and files
        AssignedTo: [email protected]
        ReportedBy: [email protected]
                CC: [email protected], [email protected],
                    [email protected], [email protected]


Created an attachment (id=7326)
 --> (https://bugzilla.wikimedia.org/attachment.cgi?id=7326)
Modification to LocalFile::getHistory to allow custom repos

FileRepo has a parameter that allows custom factory for creating file object
from a row($oldFileFromRowFactory), but prevents it from working because
LocalFile::getHistory hardcodes as follows:

$r[] = OldLocalFile::newFromRow( $row, $this->repo );

This fix would allow the existing configuration option to work.

There is an alternative work-around which is to overwrite getHistory in the
custom Repo, but since the configuration option already exists, it might make
sense to actually make it work.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to