https://bugzilla.wikimedia.org/show_bug.cgi?id=66757
Bug ID: 66757
Summary: MWHttpRequest check for noproxy is inverted
Product: MediaWiki
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: General/Unknown
Assignee: [email protected]
Reporter: [email protected]
Web browser: ---
Mobile Platform: ---
Flags: Backport_to_Stable+
Bug #44113 claims to address this very statement which now reads
if ( $this->proxy || !$this->noProxy ) {
return;
To break this out:
if ( # if
$this->proxy # the proxy is already set
|| # or
!$this->noProxy # noProxy is not set
) {
return;
Instead, it should read "If the proxy is already set or noProxy is set":
if ( $this->proxy || $this->noProxy ) {
return;
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
