https://bugzilla.wikimedia.org/show_bug.cgi?id=22967
--- Comment #15 from Arod Shatil <[email protected]> 2010-05-06 08:13:20 UTC --- nice. one small nitpick, though: i find it aesthetically displeasing that in the three different points the function "checkSummary" returns, three different mechanisms are used for return value: for special chars you use the return value of the function itself. when the string is too long you set both e.preventDefault() and e.returnValue, but not the return value of the function, and in all other cases you do not set any property on e, and leave the function return value undefined. i think you probably want to add return false; when len > 250, and return true; just before the last "}" of checkSummary. and a practical question: could you please add a couple of lines instructing me how to add this script to my user space (personal scripts or somesuch) in he.wikipedia, so i can test it? (can't test it on my own wiki, because i removed the 200 chars limit in the DB and increased the php limit to 400...) peace. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
