https://bugzilla.wikimedia.org/show_bug.cgi?id=65073

Helder <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |easy
                URL|https://www.mediawiki.org/w |https://github.com/wikimedi
                   |iki/MediaWiki:Gadget-UTCLiv |a/mediawiki-extensions-Vect
                   |eClock.js                   |orBeta/blob/master/resource
                   |                            |s/compactPersonalBar/compac
                   |                            |tPersonalBar.js#L89-L107
            Summary|CPB: Incompatibility        |CPB: compactPersonalBar.js
                   |between Compact Personal    |reimplements
                   |Bar and UTCLiveClock        |mw.util.addPortletLink
                   |                            |without keeping it
                   |                            |backwards compatible
                   |                            |(breaks UTCLiveClock)

--- Comment #3 from Helder <[email protected]> ---
Copying my comments from
https://gerrit.wikimedia.org/r/#/c/99586/10/resources/compactPersonalBar/compactPersonalBar.js,unified
[The $li from line 71] is not being used. $li should store the 'li' returned by
the createItem(...) call which is a few lines below. That would probably fix
bug 65073.

[On line 89 it ] should return $li[0] as in
https://github.com/wikimedia/mediawiki-core/blob/master/resources/src/mediawiki/mediawiki.util.js#L343

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to