https://bugzilla.wikimedia.org/show_bug.cgi?id=68556
--- Comment #2 from Michael M. <[email protected]> --- (In reply to Derk-Jan Hartman from comment #1) > Are we sure that that is a regression ? Because if a take a peek at > textSelection, it seems like it would have done that in the past as well.. Yes, I am sure. I have CodeEditor disabled, and use several user scripts that use the textSelection API, and they just broke yesterday. After a quick look: When you disable CodeEditor, context.$iframe is set to undefined [1], which previously was recognized by textSeclection as to use the default methods, while the mentioned change removed that check. So now the code always tries to call the methods provided by CodeEditor, but these fail when it is disabled. [1] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCodeEditor/56b9e4c350c122e105949b0faefa25f17253335b/modules%2Fjquery.codeEditor.js#L276 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
