https://bugzilla.wikimedia.org/show_bug.cgi?id=68556

--- Comment #5 from Derk-Jan Hartman <[email protected]> ---
Yuck...

This is really all down to the fact that the textSelection api was once a part
of the WikiEditor api.

That separation was never really properly finished and that is why in the
CodeEditor this api is now 'mixed' up with the WikiEditor api. Add to this that
CodeEditor made it  possible to enable and disable on the fly and you have one
big mess...

So this bug is because I failed to realize that the CodeEditor could be
disabled in the same session and that this would 'break' the function mapping
in:

http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCodeEditor.git/ad908b2da64da4083e10e391153112978fb9df8f/modules%2Fjquery.codeEditor.js#L517

There we basically assign the 'textSelection' api functions into the WikiEditor
api. The disabling works fine for the WikiEditor API functions, because they
listen to the conditional in L508, but the textSelection APIs are no longer
part of the wikiEditor api's and stuff start breaking.

I'm thus going to reintroduce iframe check and then submit a new patch that
does some very simple API registration to replace the textSelection API if a
textfield/area wants to do that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to