https://bugzilla.wikimedia.org/show_bug.cgi?id=68843
--- Comment #6 from Tyler Romeo <[email protected]> --- (In reply to Kunal Mehta (Legoktm) from comment #5) > Ideas on how to fix... > > * Have User::load() call loadPasswords() - fixes all back-compat issues Would rather not, for the same reason load() does not call loadOptions() > * Make loadPasswords() public This makes sense, and I'm not even sure why I didn't make it public in the first place. > * Add getPassword()/getTemporaryPassword() accessors and make the member > variables private This also makes sense. And while we're at it, also make $mId, $mName, $mRealName, etc. private since you shouldn't be accessing those directly either. > * Have MM call checkPassword() with a dummy value and then check ->mPassword > directly (ewwww) > ewwww Agreed. Stick with above. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
