https://bugzilla.wikimedia.org/show_bug.cgi?id=68843
Kunal Mehta (Legoktm) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |PATCH_TO_REVIEW --- Comment #7 from Kunal Mehta (Legoktm) <[email protected]> --- (In reply to Tyler Romeo from comment #6) > (In reply to Kunal Mehta (Legoktm) from comment #5) > > * Make loadPasswords() public > > This makes sense, and I'm not even sure why I didn't make it public in the > first place. If we add the accessors, there should be no reason to do this I think. > > > * Add getPassword()/getTemporaryPassword() accessors and make the member > > variables private > > This also makes sense. And while we're at it, also make $mId, $mName, > $mRealName, etc. private since you shouldn't be accessing those directly > either. Ib79ce01a47f90af681e376ce918eda559b4b94a6. Will do a second patch once extensions accessing directly are fixed (MassMessage, AbuseFilter, OpenID). -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
