https://bugzilla.wikimedia.org/show_bug.cgi?id=69445
--- Comment #9 from Brad Jorsch <bjor...@wikimedia.org> --- (In reply to Gilles Dubuc from comment #7) > The fact that people who aren't developers and/or who don't understand what > custom JS they're deploying to millions of users is the problem. It's not a > situation that needs to be perpetuated through dumbed-down on-wiki code > review. I've heard that same argument as to why wikitext is better than VisualEditor. I didn't agree then, and I don't agree now: making the process technically difficult to try to discourage "unqualified" contributors isn't a very well-targeted heuristic. Even if the people affected are smart enough to be able to figure out the process, they may well decide the effort isn't worth it. (In reply to MZMcBride from comment #6) > Code is the enemy; less code is better. Rather than looking at ways to > impose code review on wiki communities, we should first look for ways to > centralize code (global gadgets) and we should look for ways to make the > current site-wide JavaScript hacks no longer necessary. While having more code in gadgets rather than in common.js is good, it's orthogonal to the need for a good code review process that's actually usable by wiki users. The global gadgets will still need a code review process. Wiki users might accept having to go to a Commons-like site instead of doing it on their local wiki (and in the long run they'll probably have to), but they're unlikely to accept something that requires they install software locally, sign up for a non-SUL account, figure out ssh keys, publish an email address publicly, and so on. FlaggedRevs isn't a good model, because we need merging of proposed changes rather than a linear history. I don't know whether CodeReview will do pre-commit review, which is probably a necessity. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
