https://bugzilla.wikimedia.org/show_bug.cgi?id=23611
--- Comment #13 from Ichiro <[email protected]> 2010-06-18 22:58:50 UTC --- Thank you! On the whole it looks fine. A couple of relatively minor comments, possibly not related to this change: 1. Auto-expanding/animated search bar is annoying, non-standard and it's a bad idea from an accessibility perspective. I understand why it was done, but let's face it, it's really a bandage on a bad design. It boils down to the fact that the place is crammed and the search bar does not belong there. "Page", "Discussion", "Read", "Edit", "View History"... all actions performed on the page/article currently displayed. Search? Action performed on the site that takes you somewhere else. I am not of the "OMG SEARCH BAR BACK TO THE LEFT!!1!" camp, but it just does not belong where it is now, logically. I would put it above "Page" and "Discussion" tab, on the right of the logo. Anyway, if you must expand it, did you consider auto-expanding it only when necessary? 2. Auto-expansion is triggered every time I re-visit the page (in Firefox, just switch to another tab and switch back, you get the annoying animation again). 3. The caret disappears sometimes, although the focus remains on the search box and I can type and move around. I cannot say how to reproduce it but just play around a little. It happens more often than not. 4. The half-second delay that the bar takes to de-emphasize the search string within the suggestion list as you delete characters feels unnatural because one expects it to be a very quick calculation and it should be near-instantaneous. Same for emphasizing when you type new characters. I know that there is a remote data-fetch and it cannot be as quick as it is in a local application (e.g. Firefox address bar), but just to let you know that it's noticeable. 5. As previously discussed, if you hit ENTER when a selection that was reached via the mouse (and not via the keyboard) is active ignores the typed text and goes after the selection. This still seems wrong to me. I cannot come up with a realistic scenario that would annoy someone, but I would not be surprised of hearing one later on. Thanks again for the fix. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
