https://bugzilla.wikimedia.org/show_bug.cgi?id=23611
--- Comment #18 from Ichiro <[email protected]> 2010-06-20 14:19:42 UTC --- Cool, please let me know when it's available for testing. >From the diff, it looks like you opted for adding code instead of removing it, which is probably for a good reason, but I'd just like to make sure that you understand my proposed fix. Current code with your fix (my interpretation): when ENTER is hit, if there is a selection, work out whether it was achieved through mouse or keyboard. If via mouse, ignore selection. If via keyboard, fill in the text with the selection and search it. My proposed fix (equivalent behaviour): when ENTER is hit, ignore any suggestion selection and always search for whatever is currently in the text box. If the selection was done via keyboard, the text box will already contain the correct string. Less code = less potential bugs, but it's probably me who is missing something... Thanks -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
