https://bugzilla.wikimedia.org/show_bug.cgi?id=22093
--- Comment #17 from Max Semenik <[email protected]> 2010-07-27 21:45:09 UTC --- Note that we're going to ditch the current installer pretty soon, so it's worth concentrating on new-installer instead to avoid a double effort. -if( !defined( 'MEDIAWIKI_INSTALL' ) ) { +if ( !defined( 'MEDIAWIKI_INSTALL' ) ) { Your patch has lots of whitespace-only changes, this makes reviewing MUCH harder. Committing changes of such scale combimed with reformatting is completely out of the question. - ## DB2 specific: + # # DB2 specific: This is even weirder, did you use an automated source formatter? If so, it should be fixed not to screw things up. + else if ( $conf->DBtype == 'mssqlnative' ) { + error_reporting( E_ALL ); Why do you clear E_STRICT here? + # BEGIN DatabaseMssqlNative hack + # Since MSSQL doesn't recognize the infinity keyword, set date manually. + # TO-DO: Refactor for better DB portability and remove magic date + $dbw = wfGetDB( DB_MASTER ); + if ( $dbw instanceof DatabaseMssqlNative ) { 1) Don't connect to master just to find out your DB type. DB_SLAVE is more than sufficient. 2) Use getType() instead of instanceof + $res = $this->doQuery( "SELECT NAME AS idColumn FROM SYS.IDENTITY_COLUMNS WHERE OBJECT_NAME(OBJECT_ID)='{$tableRaw}'" ); Needs to be cached. You don't need to reimplement stuff such as DatabaseBase::ping() and getLag(). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
